Re: [ 13/48] s390/pci: Implement IRQ functions if !PCI

From: Martin Schwidefsky
Date: Wed Jun 19 2013 - 03:09:34 EST


On Tue, 18 Jun 2013 18:35:40 +0100
Ben Hutchings <ben@xxxxxxxxxxxxxxx> wrote:

> On Tue, Jun 18, 2013 at 09:17:39AM -0700, Greg Kroah-Hartman wrote:
> > From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> >
> > 3.9-stable review patch. If anyone has any objections, please let me know.
> >
> > ------------------
> >
> > From: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> >
> > commit c46b54f7406780ec4cf9c9124d1cfb777674dc70 upstream.
> >
> > All architectures must implement IRQ functions. Since various
> > dependencies on !S390 were removed, there are various drivers that can
> > be selected but will fail to link. Provide a dummy implementation of
> > these functions for the !PCI case.
> [...]
>
> This breaks !SMP builds, so it's probably best to defer this until the
> following fix is in mainline.

I guess that all of the relevant kernels that are build for s390 are SMP
enabled. The patch fixes fallout in a number of PCI drivers and should
go in as is. The patch to fix the !SMP build will go on top.

--
blue skies,
Martin.

"Reality continues to ruin my life." - Calvin.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/