Re: [PATCHv2 2/2]misc: Use schedule_(raw_)spin_unlock andschedule_(raw_)spin_unlock_irq

[Steven Rostedt]

On Tue, 2013-06-18 at 20:03 +0400, Kirill Tkhai wrote:
> Use helpers where possible (All directories except arch/.)

Also, this change log needs to be a bit better. Do not assume that
people have read the previous change. A year from now, when someone does
a git blame and sees this change, they will probably curse at this
explanation.

Add here the explanation that spin_unlock() calls preempt_enable() which
can schedule. But there are several locations that explicitly call
schedule after unlocking a spin lock. To prevent the double schedule,
use this schedule_spin_unlock() API.

-- Steve

> 
> Signed-off-by: Kirill Tkhai <tkhai@xxxxxxxxx>
> CC: Steven Rostedt <rostedt@xxxxxxxxxxx>
> CC: Ingo Molnar <mingo@xxxxxxxxxx>
> CC: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> CC: LKML


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/