Re: [PATCH]amilo-rfkill: add depends on i8042 in Kconfig

From: Ben Hutchings
Date: Tue Jun 18 2013 - 09:05:13 EST


On Tue, 2013-06-18 at 17:21 +0800, Xiong Zhou wrote:
> From: Xiong Zhou <jencce.kernel@xxxxxxxxx>
>
> Fix randconfig build failure for Amilo x86 platform driver.
> AMILO_RFKILL requires SERIO_I8042 being available.
>
> amilo-rfkill.c:(.text+0x108b5b): undefined reference to `i8042_lock_chip'
> amilo-rfkill.c:(.text+0x108b69): undefined reference to `i8042_command'
> amilo-rfkill.c:(.text+0x108b71): undefined reference to `i8042_unlock_chip'
>
> Reported-by: Jim Davis <jim.epost@xxxxxxxxx>
> Signed-off-by: Xiong Zhou <jencce.kernel@xxxxxxxxx>

Acked-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>

But I thought somehow sent this same fix a while back...

Ben.

> ---
> drivers/platform/x86/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 8577261..37645b9 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -176,6 +176,7 @@ config FUJITSU_TABLET
> config AMILO_RFKILL
> tristate "Fujitsu-Siemens Amilo rfkill support"
> depends on RFKILL
> + depends on SERIO_I8042
> ---help---
> This is a driver for enabling wifi on some Fujitsu-Siemens Amilo
> laptops.

--
Ben Hutchings
Humans are not rational beings; they are rationalising beings.

Attachment: signature.asc
Description: This is a digitally signed message part