Re: [PATCH] ARM: sched_clock: Load cycle count after epoch stabilizes

From: John Stultz
Date: Mon Jun 17 2013 - 17:50:13 EST


On 06/17/2013 12:51 PM, Stephen Boyd wrote:
John,

I just saw your pull request for making this code generic. I believe
this patch fixes a bug that nobody has seen in practice so it's probably
fine to delay this until 3.11.

Also, I've just noticed that "ARM: sched_clock: Return suspended count
earlier" that I sent in that series is going to break the arm
architected timer path because they're circumventing all this epoch_ns
code. It would be better if you could replace that patch with this patch
because this optimizes it in the same way and also fixes a bug at the
same time.

Sorry, could you clarify a bit more? The above sounds like there are two issues, but you only sent one patch.

I'm also not sure how to proceed with the patch you sent, since it collides with the patch that moves sched_clock to be generic.

Could you refactor the change on-top of git branch I sent to Thomas? Otherwise I'll have to withdraw the pull request, and we'll probably miss 3.11 for the generic sched_clock change.

thanks
-john


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/