Re: [PATCH v2 3/7] mm/writeback: commit reason ofWB_REASON_FORKER_THREAD mismatch name

From: Tejun Heo
Date: Mon Jun 17 2013 - 16:27:18 EST


On Mon, Jun 17, 2013 at 05:41:44PM +0800, Wanpeng Li wrote:
> On Mon, Jun 17, 2013 at 10:30:30AM +0200, Michal Hocko wrote:
> >On Sun 16-06-13 09:14:46, Wanpeng Li wrote:
> >> After commit 839a8e86("writeback: replace custom worker pool implementation
> >> with unbound workqueue"), there is no bdi forker thread any more. However,
> >> WB_REASON_FORKER_THREAD is still used due to it is somewhat userland visible
> >
> >What exactly "somewhat userland visible" means?
> >Is this about trace events?
>
> Thanks for the question, Tejun, could you explain this for us? ;-)

Yeah, I was referring to the WB_REASON strings in
include/trace/events/writeback.h. We can rename the internal constant
and leave the string alone too but I don't think it matters either
way.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/