Re: [PATCH 4/4 v2] silicom: checkpatch: errors caused by macros

[Joe Perches]

On Mon, 2013-06-17 at 21:20 +0200, Lorenz Haspel wrote:
> fixed checkpatch error:
> added parenthesis around complex macro.
> 
> Macro with return was only used once in the code,
> so I expandet it in-place.
[]
> diff --git a/drivers/staging/silicom/bpctl_mod.c b/drivers/staging/silicom/bpctl_mod.c
[]
> -#define lock_bpctl()					\
> -if (down_interruptible(&bpctl_sema)) {			\
> -	return -ERESTARTSYS;				\
> -}							\
> -
>  #define unlock_bpctl()					\
>  	up(&bpctl_sema);

Symmetry please.

Most likely, this unlock_bpctl macro is only used once too.
I suggest removing it as well.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/