Re: [PATCH 4/4] solicom: checkpatch: added parenthesis to macros

[Joe Perches]

On Mon, 2013-06-17 at 18:26 +0200, Lorenz Haspel wrote:
> fixed checkpatch error:
> added parenthesis around complex macros.
[]
> diff --git a/drivers/staging/silicom/bpctl_mod.c b/drivers/staging/silicom/bpctl_mod.c
[]
> @@ -44,9 +44,11 @@ MODULE_VERSION(BP_MOD_VER);
>  spinlock_t bpvm_lock;
>  
>  #define lock_bpctl()					\
> -if (down_interruptible(&bpctl_sema)) {			\
> -	return -ERESTARTSYS;				\
> -}							\
> +do {							\
> +	if (down_interruptible(&bpctl_sema)) {		\
> +		return -ERESTARTSYS;			\
> +	}						\
> +} while (0)

Macros with goto or return are also poor style.
Probably better to expand these in-place instead.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/