Re: [PATCH] dmatest: masking tests for channel capabilities

[Dave Jiang]

On 06/17/2013 01:59 AM, Andy Shevchenko wrote:
> On Thu, Jun 13, 2013 at 8:24 PM, Jubin Mehta <jubin.mehta@xxxxxxxxx> wrote:
> > +++ b/drivers/dma/dmatest.c
> > +/*
> > + * Capability Mask Bits.The bits in the cap_mask denote the masking of
> > + * the hardware capabilities of the dma channel.
> > + *
> > + * DMA_CAP_MEMCPY:  Bit 0 for enabling DMA_MEMCPY capability
> > + * DMA_CAP_XOR:     Bit 1 for enabling DMA_XOR capabilit
> > + * DMA_CAP_PQ:      Bit 2 for enabling DMA_PQ capability
> > + * DMA_CAP_ALL:     Enable all the capabilities of the channel
> > + */
> > +#define DMA_CAP_MEMCPY         (1 << 0)
> > +#define DMA_CAP_XOR            (1 << 1)
> > +#define DMA_CAP_PQ             (1 << 2)
> Can we reuse DMA_MEMCPY and so on from enum dma_transaction_type?

The issue is that the originals are enum types. We can't pass bitmap 
type (dma_cap_mask_t) through sysfs. So to use those enums for what we 
want to do it would have to be someting like:
(1 << DMA_MEMCPY)

And also in that case for user scripts you have bits that are here and 
there for the bitmask instead of something simple and sequential.

--

Dave Jiang
Application Engineer, Storage Divsion
Intel Corp.
dave.jiang@xxxxxxxxx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/