Re: [PATCH][RFC] kernel/cpu: do not change the cpus_allowed of thecurrent task when unplugging cpus

From: Sebastian Andrzej Siewior
Date: Mon Jun 17 2013 - 07:49:53 EST


On 06/17/2013 12:48 PM, Zhao Chenhui wrote:
> I don't think it is necessary to change the mask. migration_call() invoked by
> the cpu notify "CPU_DYING" will remove all running tasks from the dying cpu.
> Even if the current task is running on the dying cpu, it will be transfered
> to another online cpu.

I had here hiccups if the task was running on the CPU which should go
down.

> I guess that changing the mask benefits the latency of the system.
> Please correct me.

I don't get this. Lets say your system has CPUs 0-15 and you pin your
application to CPU0. After this application brings CPU15 down it is
allowed to run on CPUs 0-14. This is wrong and has been corrected. The
CPU down mechanism should not affected CPU mask of the application.

>
> -Chenhui
>

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/