Re: [PATCH Resend] pinctrl: exynos: Fix build breakage

[Sachin Kamat]

On 17 June 2013 16:55, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> On Mon, Jun 17, 2013 at 11:38 AM, Sachin Kamat <sachin.kamat@xxxxxxxxxx> wrote:
>
>> 'exynos_wkup_irq_ack' should be defined ahead of its call.
>>
>> Fixes the following error:
>> drivers/pinctrl/pinctrl-exynos.c: In function ‘exynos_wkup_irq_mask’:
>> drivers/pinctrl/pinctrl-exynos.c:299:3: error: implicit declaration of
>> function ‘exynos_wkup_irq_ack’ [-Werror=implicit-function-declaration]
>>    exynos_wkup_irq_ack(irqd);
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx>
>> Cc: Doug Anderson <dianders@xxxxxxxxxxxx>
>> ---
>> Fixed the commit message.
>> ---
>
> Applied.

Thanks.

>
> Usually you should state which commit caused
> the problem in the commit message.

Usually I do. But in this case it was not caused by a single commit
per se but a combination.
Hence I wasn't sure if I should mention both as the ones causing it.


-- 
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/