Re: [PATCH] Re: [Patch] MCE, APEI: Don't enable CMCI when FirmwareFirst mode is set in

From: Naveen N. Rao
Date: Mon Jun 17 2013 - 06:31:57 EST


On 06/17/2013 01:51 PM, Borislav Petkov wrote:
On Mon, Jun 17, 2013 at 01:41:03PM +0530, Naveen N. Rao wrote:
Yes, we used to poll since we do not get notified via MCE/CMCI.
However, with firmware first set in CMC structure, the firmware is
now controlling all corrected error reporting for these banks. So, we
should not be looking at these MCA banks at all.

Ok,

then the bank polling disabling part should be generic code (i.e., not
in mce_intel) since it is part of the APEI crap. The CMCI disabling
should be Intel-specific only as AMD has a similar mechanism which we'll
need to disable at some point too.

Ok, I'll move mce_disable_bank() to mce.c and re-structure the patch around that.

Thanks,
Naveen

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/