Re: [PATCH 2/2] mn10300: Fix include dependency in irqflags.h

From: Geert Uytterhoeven
Date: Mon Jun 17 2013 - 06:11:49 EST


On Mon, Jun 17, 2013 at 11:07 AM, David Howells <dhowells@xxxxxxxxxx> wrote:
> ddaney.cavm@xxxxxxxxx wrote:
>
>> #ifndef __ASSEMBLY__
>> -#include <linux/smp.h>
>> +/* linux/smp.h <- linux/irqflags.h needs asm/smp.h first */
>> +#include <asm/smp.h>
>> #endif
>
> If you make this change, is the #ifndef __ASSEMBLY__ still necessary, I
> wonder...

Seems to be fine, for asb2303_defconfig.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/