Re: [PATCH v2 5/7] mm/page_alloc: fix doc for numa_zonelist_order

[Michal Hocko]

On Sun 16-06-13 09:14:48, Wanpeng Li wrote:
> The default zonelist order selecter will select "node" order if any node's
> DMA zone comprises greater than 70% of its local memory instead of 60%,
> according to default_zonelist_order::low_kmem_size > total * 70/100.

Hmm, interesting. This comment has been incorrect since f0c0b2b808
(change zonelist order: zonelist order selection logic).
> 
> Signed-off-by: Wanpeng Li <liwanp@xxxxxxxxxxxxxxxxxx>

Reviewed-by: Michal Hocko <mhocko@xxxxxxx>

> ---
>  Documentation/sysctl/vm.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/sysctl/vm.txt b/Documentation/sysctl/vm.txt
> index a5717c3..15d341a 100644
> --- a/Documentation/sysctl/vm.txt
> +++ b/Documentation/sysctl/vm.txt
> @@ -531,7 +531,7 @@ Specify "[Dd]efault" to request automatic configuration.  Autoconfiguration
>  will select "node" order in following case.
>  (1) if the DMA zone does not exist or
>  (2) if the DMA zone comprises greater than 50% of the available memory or
> -(3) if any node's DMA zone comprises greater than 60% of its local memory and
> +(3) if any node's DMA zone comprises greater than 70% of its local memory and
>      the amount of local memory is big enough.
>  
>  Otherwise, "zone" order will be selected. Default order is recommended unless
> -- 
> 1.8.1.2
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@xxxxxxxxxx  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>

-- 
Michal Hocko
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/