Re: [PATCH v3] i2c: vt8500: Add support for I2C bus on WondermediaSoCs

From: Wolfram Sang
Date: Mon Jun 17 2013 - 03:11:08 EST


On Sun, Jun 16, 2013 at 09:58:53AM +1200, Tony Prisk wrote:
> On 15/06/13 23:18, Wolfram Sang wrote:
> >On Sat, Jun 15, 2013 at 09:52:16AM +1200, Tony Prisk wrote:
> >>This patch adds support for the I2C bus controllers found on Wondermedia
> >>8xxx-series SoCs. Only master-mode is supported.
> >>
> >>Signed-off-by: Tony Prisk <linux@xxxxxxxxxxxxxxx>
> >>---
> >...
> >
> >>+/* REG_TR */
> >>+#define SCL_TIMEOUT(x) (((x) & 0xFF) << 16)
> >I assume this should be << 8 since all regs are 16 bit wide.
> >
> >Fixed it locally and ready to apply. Please confirm or send a proper
> >fix. Rest looks fine.
> >
> >Thanks for the submission!
> >
> It should be << 8. Please apply your locally corrected version.

Applied to for-next, thanks!

Attachment: signature.asc
Description: Digital signature