Re: [PATCH 1/4] sys: remove unnecesscary parameter of set_one_prio

[Andrew Morton]

On Thu, 30 May 2013 01:08:25 -0700 Joe Perches <joe@xxxxxxxxxxx> wrote:

> On Thu, 2013-05-30 at 15:58 +0800, liguang wrote:
> []
> > diff --git a/kernel/sys.c b/kernel/sys.c
> []
> > -static int set_one_prio(struct task_struct *p, int niceval, int error)
> > +static int set_one_prio(struct task_struct *p, int niceval)
> 
> Umm, error is forwarded through do_each loops.
> 
> Are you sure you can do this without
> changing any return code behaviors?

yes, you're right.  The first time around, -ESRCH gets rewritten to 0
and the zero propagates, as long as nobody hits an error which isn't
-ESRCH.  I'm not sure this was the most straightforward possible
implementation :(

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/