Re: [PATCH] of: Export of_irq_count for using in modules

[Jean-Christophe PLAGNIOL-VILLARD]

On 10:14 Fri 31 May     , Michal Simek wrote:
> Hi Jean-Christophe,
> 
> On 05/30/2013 10:17 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 15:49 Thu 30 May     , Michal Simek wrote:
> >> Export of_irq_count for modules.
> > 
> > can you explain why do you need to call of_irq_count
> 
> I need to count number of irq written in the DTS node.
> It is not fixed size that's why I need to proper way how to
> find it out.
> 
> I am using this loop.
> 	count = of_irq_count(pdev->dev.of_node);
> 	/* Alloc IRQ based on DTS to be sure that no other driver will use it */
> 	while (count--) {
> 		tmp->irq = irq_of_parse_and_map(pdev->dev.of_node, count);
> 		dev_info(&pdev->dev, "%d: Alloc irq: %d\n", count, tmp->irq);
> 		ret = request_irq(tmp->irq, zynq_remoteproc_interrupt, 0,
> 					dev_name(&pdev->dev), &pdev->dev);
> 		if (ret) {
> 			...
> 		}
> 	}
> 
> But of course if you think that this is incorrect to export it
> I can use what it is in of_irq_count body
> 368 int of_irq_count(struct device_node *dev)
> 369 {
> 370         int nr = 0;
> 371
> 372         while (of_irq_to_resource(dev, nr, NULL))
> 373                 nr++;
> 374
> 375         return nr;
> 376 }
> 
> Because of_irq_to_resource is exported for modules.
> Or is there any better way how to loop over all interrupts in DT node?

can just explain me why you need to call irq_of_parse_and_map in your driver?

as the irq will be provided in the resources normally

Best Regards,
J.
> 
> Thanks,
> Michal
> 
> -- 
> Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
> w: www.monstr.eu p: +42-0-721842854
> Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
> Maintainer of Linux kernel - Xilinx Zynq ARM architecture
> Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/