Re: [PATCH v2 9/9] gpio-tz1090-pdc: add TZ1090 PDC gpio driver

[James Hogan]

On 29/05/13 17:12, James Hogan wrote:
> On 29/05/13 16:38, Linus Walleij wrote:
>> On Fri, May 24, 2013 at 6:21 PM, James Hogan <james.hogan@xxxxxxxxxx> wrote:
>>> +Optional properties:
>>> +- gpio-ranges: Mapping to pin controller pins
>>> +
>>> +- interrupts: Individual syswake interrupts (other GPIOs cannot interrupt)
>>> +
>>> +
>>> +Example:
>>> +
>>> +       pdc_gpios: gpio-controller@02006500 {
>>> +               gpio-controller;
>>> +               #gpio-cells = <2>;
>>> +
>>> +               compatible = "img,tz1090-pdc-gpio";
>>> +               reg = <0x02006500 0x100>;
>>> +
>>> +               interrupt-parent = <&pdc>;
>>> +               interrupts =    <1 0 0>,        /* Syswake 0 */
>>> +                               <1 1 0>,        /* Syswake 1 */
>>> +                               <1 2 0>;        /* Syswake 2 */
>>> +       };
>>
>> Interrupt flags seem to be undocumented here.
> 
> Hmmm yes, good spot.

Looking again at this, the driver doesn't expose any new interrupts.
These 3 interrupts are simply passed on by the gpio chip's to_irq()
callback. The flags in the example depend entirely on the interrupt
parent, in this case the PDC irq driver in patch 2, so they don't need
documenting here.

Cheers
James

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/