Re: [PATCH v1 00/13] mrst refactoring patches

From: Andy Shevchenko
Date: Fri May 31 2013 - 04:40:12 EST


On Thu, May 30, 2013 at 5:45 AM, Sathyanarayanan Kuppuswamy
<sathyanarayanan.kuppuswamy@xxxxxxxxx> wrote:
> As Intel rolling out more SoC's after Moorestown, we need to re-structure
> the code in a way that is backward compatible and easy to expand.This
> patch set implements a flexible way to support multiple boards and devices.
>
> Patch 1 - 5 fixes some indentation issue, compiler warnings and renames.
> Patch 6 - 13 refactors mrst code.

First of all, please, remove Gerrit IDs from the commit messages.

> Andy Shevchenko (2):
> sfi: fix compiler warnings
> gpiolib: append SFI helpers for GPIO API

I still insist you may move my patches before you do split to the device_lib.

Now you do some cleaning up, than split, than move to new GPIO API.
In proposed case you will have one step less.

Other comments are provided by patch.

P.S. There are new versions of my patches. One of them was published
already, I put a link in the comment, the other will be ready soon
(addressing Linus' comments).

--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/