Re: [PATCH v3] watchdog: Add hook for kicking in kdump path

From: Wim Van Sebroeck
Date: Thu May 30 2013 - 17:54:32 EST


Hi Guenter,

> > Only when you set the .parent field in the watchdog_device data you will get the
> > referal in the /sys/class/... tree. In iTCO_wdt.c you have the following code
> > that does that: iTCO_wdt_watchdog_dev.parent = dev->dev.parent;
> >
> > From the watchdog-kernel-api documentation:
> > * parent: set this to the parent device (or NULL) before calling
> > watchdog_register_device.
> >
> Hi Wim,
>
> unfortunately that only works if the driver is instantiated as platform driver,
> PCI driver, or similar, where a parent device exists. Some drivers are, however,
> instantiated directly from the init function (the BookE driver is an example).
> What is the recommended action in this case ? Convert it to a platform driver ?

If you don't have a bus related driver (like a pci-driver) then indeed it's a
conversion to a platform driver.

Kind regards,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/