Re: [PATCH] mm: sparse: use __aligned() instead of manual paddingin mem_section
From: Cody P Schafer
Date: Thu May 30 2013 - 12:36:28 EST
On 05/29/2013 05:54 PM, Jiang Liu wrote:
On Thu 30 May 2013 07:14:39 AM CST, Cody P Schafer wrote:
Also, does anyone know what causes this alignment to be required here? I found
this was breaking things in a patchset I'm working on (WARNs in sysfs code
about duplicate filenames when initing mem_sections). Adding some documentation
for the reason would be appreciated.
Hi Cody,
I think the alignment requirement is caused by the way the
mem_section array is
organized. Basically it requires that PAGE_SIZE could be divided by
sizeof(struct mem_section).
So your change seems risky too because it should be aligned to power of
two instead
of 2 * sizeof(long).
Well, if that's the case then this patch is wrong, and manual padding
may be the only way to go. :(
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/