Re: [PATCH v2] ata: increase retry count but shorten duration forCalxeda controller

[Timur Tabi]

On 05/30/2013 09:38 AM, Sergei Shtylyov wrote:
>>> >> -	const unsigned long *timing = sata_ehc_deb_timing(&link->eh_context);
>>> >> +	const unsigned long timing[] = { 5, 100, 500};
>> > You'll save space and time if you also make this array "static",
>> > otherwise the compiler will build the array every time this function is
>> > called.
>     No, *const* specifier is enough to not build this array every time. 
> It will be put into the .const section.

Ok.  Now that I think about it, that makes sense.

-- 
Timur Tabi
Software Developer at Calxeda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/