Re: [PATCH -next v2] dmaengine: ste_dma40: fix error return code in d40_probe()

From: Linus Walleij
Date: Thu May 30 2013 - 03:41:59 EST


On Thu, May 30, 2013 at 6:32 AM, Wei Yongjun <weiyj.lk@xxxxxxxxx> wrote:

> From: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
>
> In many of the error handling case, the return value 'ret' not set
> and 0 will be return from d40_probe() even if error, but we should
> return a negative error code instead in those error handling case.
> This patch fixed them, and also removed useless variable 'err'.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
> ---
> v1 -> v2: rebased on linux-next.git

I've tentatively applied this to my dma40 branch, waiting for Vinod
to ACK it.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/