Re: [PATCH 2/2] sched:fix: Signed overflow prevention for vacancycalculation

From: Alex Shi
Date: Wed May 29 2013 - 21:51:38 EST


On 05/23/2013 04:34 PM, Lukasz Majewski wrote:
> Nasty bug with vacancy calculation has been fixed.
> In the if statement the FULL_UTIL is a large constant, max_cfs_util()
> returns unsigned and putil is also defined as unsigned. The outcome
> is that this condition is always true.
>
> As observed, this was the reason for frequent jumps of processes between
> CPUs.
>
> Signed-off-by: Lukasz Majewski <l.majewski@xxxxxxxxxxx>
> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>

Thanks for the catching!
I do a little change, would you like to keep the authorship?

---