Re: [PATCH] usb: gadget: r8a66597-udc: do not unlock unheld spinlockin r8a66597_sudmac_irq()

[Felipe Balbi]

HI,

On Thu, May 30, 2013 at 12:51:37AM +0400, Alexey Khoroshilov wrote:
> r8a66597_irq() processes sudmac part (r8a66597_sudmac_irq()) before locking r8a66597->lock.
> But transfer_complete(), that is called inside (r8a66597_sudmac_irq()->sudmac_finish()->transfer_complete()),
> expects r8a66597->lock is locked. As a result unheld spinlock can be unlocked.
> 
> The patch just moves locking before calling r8a66597_sudmac_irq().
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Alexey Khoroshilov <khoroshilov@xxxxxxxxx>

should this go to stable ? Looks like this bug has been there since
2.6.32.

-- 
balbi

Attachment: signature.asc
Description: Digital signature