Re: [PATCH 3/4] KVM: PPC: Add support for IOMMU in-kernel handling

[Scott Wood]

On 05/29/2013 06:29:13 PM, Alexey Kardashevskiy wrote:
> On 05/30/2013 09:14 AM, Scott Wood wrote:
> > On 05/29/2013 06:10:33 PM, Alexey Kardashevskiy wrote:
> >> On 05/30/2013 06:05 AM, Scott Wood wrote:
> >> > But you didn't put it in the same section as  
> KVM_CREATE_SPAPR_TCE.  0xe0
> >> > begins a different section.
> >>
> >> It is not really obvious that there are sections as no comment  
> defines
> >> those :)
> >
> > There is a comment /* ioctls for fds returned by KVM_CREATE_DEVICE  
> */
> >
> > Putting KVM_CREATE_DEVICE in there was mainly to avoid dealing with  
> the
> > ioctl number conflict mess in the vm-ioctl section, but at least  
> that one
> > is related to the device control API. :-)
> >
> >> But yes, makes sense to move it up a bit and change the code to  
> 0xad.
> >
> > 0xad is KVM_KVMCLOCK_CTRL
>
> That's it. I am _completely_ confused now. No system whatsoever :(
> What rule should I use in order to choose the number for my new  
> ioctl? :)

Yeah, it's a mess.  0xaf seems to be free. :-)

-Scott
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/