Re: [RFC PATCH] vfs: add permute operation

From: Zach Brown
Date: Wed May 29 2013 - 19:02:31 EST


> >> +static void sort_parents3(struct dentry **p)
> >> +void sort_parents(struct dentry **p, unsigned *nump)
> >
> > Yikes, that's a bunch of fiddly code. Is it *really* worth all that to
> > avoid calling the generic sort helpers?
>
> AFAICS, I cannot make the compare function transitive, e.g.: A is
> descendant of C but B is unrelated. Then what should cmp(A, B) and
> cmp(B, C) return?

Ah, of course. I wasn't reading closely enough.

- z
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/