Re: [PATCH] audit: wait_for_auditd() should use TASK_UNINTERRUPTIBLE

[Guy Streeter]

On 05/29/2013 04:59 PM, Andrew Morton wrote:
> On Fri, 24 May 2013 19:39:25 +0200 Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
> 
>> audit_log_start() does wait_for_auditd() in a loop until
>> audit_backlog_wait_time passes or audit_skb_queue has a room.
>>
>> If signal_pending() is true this becomes a busy-wait loop,
>> schedule() in TASK_INTERRUPTIBLE won't block.
> 
> And that's game over for a uniprocessor non-preempt machine, yes?
> 
>> Reported-by: Guy Streeter <streeter@xxxxxxxxxx>
> 
> And what did Guy report?  "that looks screwy"?  "my machine locked up"?
>

Our customer was in fact running a uniprocessor machine, and they reported a
system hang.
--Guy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/