Re: [RFC 0/3] saa7115: Implement i2c_board_info.platform_data

From: Jon Arne JÃrgensen
Date: Wed May 29 2013 - 16:46:03 EST


On Wed, May 29, 2013 at 10:41:15PM +0200, Jon Arne JÃrgensen wrote:
> This patch set adds handling of the i2c_board_info struct to the saa7115 driver.
> The main goal of this patch is to give the different devices with the gm7113c
> chip an opportunity to configure the chip to their needs.
>
> I've only implemented the overrides I know are necessary to get the stk1160
> and the smi2021 drivers to work.
>
> The first patch in the series sets the saa7113 init table to the defaults
> according to the datasheet. Maybe it's better to add a new initialization
> table for the gm7113c chip to avoid breaking devices that depend on the
> settings as they are now?
> That would introduce some unneeded code duplication.
>

Hi,
I just realized that there are som grave errors in patch 3 in the
series.

I'll fix them and repost this series.

Best regards,
Jon Arne JÃrgensen

> Jon Arne JÃrgensen (3):
> saa7115: Set saa7113 init to values from datasheet
> saa7115: [gm7113c] Remove unneeded register change
> saa7115: Implement i2c_board_info.platform data
>
> drivers/media/i2c/saa7115.c | 91 ++++++++++++++++++++++++------------
> include/media/saa7115.h | 109 ++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 170 insertions(+), 30 deletions(-)
>
> --
> 1.8.2.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/