Re: [PATCH v2 9/9] gpio-tz1090-pdc: add TZ1090 PDC gpio driver

[Linus Walleij]

On Fri, May 24, 2013 at 6:21 PM, James Hogan <james.hogan@xxxxxxxxxx> wrote:

> Add a GPIO driver for the low-power Powerdown Controller GPIOs in the
> TZ1090 SoC.
(...)
> +  Values for gpio specifier:
> +  - GPIO number: a value in the range 0 to 6.
> +  - GPIO flags: bit field of flags:
> +      1: active low

Use #include <dt-bindings/gpio/gpio.h>
for flags and symbolic names.

> +Optional properties:
> +- gpio-ranges: Mapping to pin controller pins
> +
> +- interrupts: Individual syswake interrupts (other GPIOs cannot interrupt)
> +
> +
> +Example:
> +
> +       pdc_gpios: gpio-controller@02006500 {
> +               gpio-controller;
> +               #gpio-cells = <2>;
> +
> +               compatible = "img,tz1090-pdc-gpio";
> +               reg = <0x02006500 0x100>;
> +
> +               interrupt-parent = <&pdc>;
> +               interrupts =    <1 0 0>,        /* Syswake 0 */
> +                               <1 1 0>,        /* Syswake 1 */
> +                               <1 2 0>;        /* Syswake 2 */
> +       };

Interrupt flags seem to be undocumented here.

Apart from this it's looking nice.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/