Re: [Xen-devel] [PATCH 2/2] x86/xen: sync the wallclock whenthe system time changes

[Jan Beulich]

>>> On 28.05.13 at 20:22, David Vrabel <david.vrabel@xxxxxxxxxx> wrote:
> @@ -199,28 +201,59 @@ static void xen_get_wallclock(struct timespec *now)
>  
>  static int xen_set_wallclock(const struct timespec *now)
>  {
> -	struct xen_platform_op op;
> -	int ret;
> -
>  	/* do nothing for domU */
>  	if (!xen_initial_domain())
>  		return -1;
>  
> -	/* Set the Xen wallclock. */
> +	/* Set the hardware RTC. */
> +	return mach_set_rtc_mmss(now);
> +
> +}

Can't you achieve the same effect in a cleaner way by overriding
x86_platform.set_wallclock only in the non-init-domain case?

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/