Re: [PATCH v2 11/14] Documentation: dt: binding: omap: am43x timer

From: Jon Hunter
Date: Tue May 28 2013 - 17:33:59 EST



On 27/05/13 15:37, Afzal Mohammed wrote:
> AM43x timer bindings.
>
> Signed-off-by: Afzal Mohammed <afzal@xxxxxx>
> ---
> Documentation/devicetree/bindings/arm/omap/timer.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/omap/timer.txt b/Documentation/devicetree/bindings/arm/omap/timer.txt
> index d02e27c..70cb398 100644
> --- a/Documentation/devicetree/bindings/arm/omap/timer.txt
> +++ b/Documentation/devicetree/bindings/arm/omap/timer.txt
> @@ -14,6 +14,8 @@ Required properties:
> ti,omap5430-timer (applicable to OMAP543x devices)
> ti,am335x-timer (applicable to AM335x devices)
> ti,am335x-timer-1ms (applicable to AM335x devices)
> + "ti,am4372-timer-1ms", "ti,am335x-timer-1ms" for AM43x 1ms timer
> + "ti,am4372-timer", "ti,am335x-timer" for AM43x timers other than 1ms one
>
> - reg: Contains timer register address range (base address and
> length).

If you are adding more compatibility strings, then this implies that the
AM43x timers are not 100% compatible with any other device listed (such
as am335x or any omap device). That's fine but you should state that in
the changelog. If the AM43x timer registers are 100% compatible with
existing devices you should not add these.

Jon

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/