Re: [PATCHv4 15/39] thp, mm: trigger bug in replace_page_cache_page()on THP

[Dave Hansen]

On 05/28/2013 05:53 AM, Kirill A. Shutemov wrote:
> Dave Hansen wrote:
>> On 05/11/2013 06:23 PM, Kirill A. Shutemov wrote:
>>> +	VM_BUG_ON(PageTransHuge(old));
>>> +	VM_BUG_ON(PageTransHuge(new));
>>>  	VM_BUG_ON(!PageLocked(old));
>>>  	VM_BUG_ON(!PageLocked(new));
>>>  	VM_BUG_ON(new->mapping);
>>
>> The code calling replace_page_cache_page() has a bunch of fallback and
>> error returning code.  It seems a little bit silly to bring the whole
>> machine down when you could just WARN_ONCE() and return an error code
>> like fuse already does:
> 
> What about:
> 
> 	if (WARN_ONCE(PageTransHuge(old) || PageTransHuge(new),
> 		     "%s: unexpected huge page\n", __func__))
> 		return -EINVAL;

That looks sane to me.  But, please do make sure to differentiate in the
error message between thp and hugetlbfs (if you have the room).

BTW, I'm also not sure you need to print the function name.  The
WARN_ON() register dump usually has the function name.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/