Re: [PATCH] power_supply: generic-adc-battery: Fix checking if noneof the channels are supported

[anish singh]

On Fri, May 24, 2013 at 11:11 PM, Axel Lin <axel.lin@xxxxxxxxxx> wrote:
> If none of the channels are supported, index is 0.
> Also ensure to return error code instead of 0 in goto second_mem_fail path.
>
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx>
Acked-by: anish kumar <anish198519851985@xxxxxxxxx>

I think anton would have already picked up.
> ---
>  drivers/power/generic-adc-battery.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/power/generic-adc-battery.c b/drivers/power/generic-adc-battery.c
> index 8cb5d7f..59a1421 100644
> --- a/drivers/power/generic-adc-battery.c
> +++ b/drivers/power/generic-adc-battery.c
> @@ -299,8 +299,10 @@ static int gab_probe(struct platform_device *pdev)
>         }
>
>         /* none of the channels are supported so let's bail out */
> -       if (index == ARRAY_SIZE(gab_chan_name))
> +       if (index == 0) {
> +               ret = -ENODEV;
>                 goto second_mem_fail;
> +       }
>
>         /*
>          * Total number of properties is equal to static properties
> --
> 1.8.1.2
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/