Re: [ 22/42] sched/debug: Fix sd->*_idx limit range avoidingoverflow

From: Ben Hutchings
Date: Mon May 27 2013 - 21:48:40 EST


On Fri, 2013-05-10 at 09:59 +0200, Ingo Molnar wrote:
> * Ben Hutchings <ben@xxxxxxxxxxxxxxx> wrote:
>
> > On Tue, 2013-04-23 at 14:52 -0700, Greg Kroah-Hartman wrote:
> > > 3.8-stable review patch. If anyone has any objections, please let me know.
> > >
> > > ------------------
> > >
> > > From: libin <huawei.libin@xxxxxxxxxx>
> > >
> > > commit fd9b86d37a600488dbd80fe60cca46b822bff1cd upstream.
> > >
> > > Commit 201c373e8e ("sched/debug: Limit sd->*_idx range on
> > > sysctl") was an incomplete bug fix.
> > [...]
> >
> > It seems like both these commits ought to be applied to earlier stable
> > branches. Or was the lack of range checking a regression after 3.4?
>
> Both should be applied indeed.
>
> They are not a huge problem as all these facilities are for debugging and
> are root-only, but the two fixes should be applied together or not at all.

I've queued up both of these for 3.2.

Ben.

--
Ben Hutchings
If at first you don't succeed, you're doing about average.

Attachment: signature.asc
Description: This is a digitally signed message part