Re: [PATCH 1/2] MIPS: cavium-octeon: cvmx-helper-board: print unknownboard warning only once

[Sergei Shtylyov]

On 27-05-2013 14:19, Sergei Shtylyov wrote:

> > When booting a new board for the first time, the console is flooded with
> > "Unknown board" messages. This is not really helpful. Board type is not
> > going to change after the boot, so it's sufficient to print the warning
> > only once.

> > Signed-off-by: Aaro Koskinen <aaro.koskinen@xxxxxx>
> > ---
> >   arch/mips/cavium-octeon/executive/cvmx-helper-board.c |    5 +++--
> >   1 file changed, 3 insertions(+), 2 deletions(-)

> > diff --git a/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
> > b/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
> > index 7c64977..e0451a0 100644
> > --- a/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
> > +++ b/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
> [...]
> > @@ -184,8 +186,7 @@ int cvmx_helper_board_get_mii_address(int ipd_port)
> >       }
> >
> >       /* Some unknown board. Somebody forgot to update this
> > function... */
> > -    cvmx_dprintf
> > -        ("cvmx_helper_board_get_mii_address: Unknown board type %d\n",
> > +    pr_warn_once("%s: Unknown board type %d\n", __func__,
> >            cvmx_sysinfo_get()->board_type);

>     Please align this line under the next char under (.

    s/under (/after (/, of course.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/