Re: [PATCH] arch: x86: platform: mrst: pr_err() need notice that'sdev->modalias' may not a NUL terminated string.

From: Sebastian Andrzej Siewior
Date: Mon May 27 2013 - 03:07:06 EST


On Sun, May 26, 2013 at 04:50:22PM +0800, Chen Gang wrote:
>
> According to the areas which use "%16.16s" within this file, the
> 'sdev->modalias' may not always be a NUL terminated string.
>
> So need use "%.16s" instead of "%s" in pr_err(), or may cause issue.

No. spi_match_id() expects a NULL terminated string and I would be suprised if
it would be otherwise. Therefore moorsetown or this files has to learn to NULL
terminate its strings.

> Signed-off-by: Chen Gang <gang.chen@xxxxxxxxxxx>

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/