On Monday 27 May 2013 12:01 PM, Kishon Vijay Abraham I wrote:Hi,
On Monday 27 May 2013 11:52 AM, Laxman Dewangan wrote:On Monday 27 May 2013 11:38 AM, Chanwoo Choi wrote:But dint you just tell on my v4 of this patch that you don’t requireOn 05/27/2013 02:54 PM, Kishon Vijay Abraham I wrote:Along with this, I also like to make the VBUS regulator control to beHi,I agree your opinion.
On Monday 27 May 2013 11:04 AM, Chanwoo Choi wrote:Hi Kishon,yeah.. Still there is some confusion with palmas_set_switch_smps10().
I have some comment about this patch
and upload modified patch to following repository
(extcon-for-palmas).
-
http://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/commit/?h=extcon-for-palmas&id=f2b7cb80699cbe1a5fd6c97ef2c600915f8d7f2c
This patchset include patch related to other module
,so I need your opinion to apply this patchset to git repository.
I think we can remove it for now and add it separately later. By this
at least we can have device mode fully functional in OMAP5. What do
you think?
But, I propose some fixes about palmas_set_switch_smps10().
I dont' prefer to call global function in exton-palmas.c from
palmas-regulator.c.
So, Why don't you use regulator consumer instead of global function?
You can register specific regulator for enabling or disabling
SMPS10_SWITCH_EN
and then control SMPS10_SWITCH_EN bit through regulator framework in
extcon-palmas.c
without calling global function.
optional here. Currently it is mandatory.
this.
http://www.spinics.net/lists/linux-doc/msg10638.html
In V4, I said remove this VBUS control and my mean was to remove all
regulator calls for VBUS enabled/disable.
I saw you just remove the platform data option to have this control and
made VBUS mandatory.
Probably some gap here.