Re: [PATCH] rtc: tps6586x: device wakeup flags correction

[Dmitry Osipenko]

23.05.2013 02:22, Andrew Morton ÐÐÑÐÑ:
> On Sun, 12 May 2013 18:25:06 +0400 Dmitry Osipenko <digetx@xxxxxxxxx> wrote:
> 
>> Use device_init_wakeup() instead of device_set_wakeup_capable() and move it
>> before rtc dev registering. This fixes issue with alarmtimer that checks wakeup
>> capability with device_may_wakeup() on device add.
> 
> Well OK, but what is this "issue"?
> 
> (form letter: When writing a changelog, please describe the
> end-user-visible effects of the bug, so that others can more easily
> decide which kernel version(s) should be fixed, and so that downstream
> kernel maintainers can more easily work out whether this patch will fix
> a problem which they or their customers are observing.)
> 

Hi, Andrew. Thanks for comment. "Issue" is that alarmtimer won't be registered
if tps6586x is the only wakeup compatible rtc in the system.

from kernel/time/alarmtimer.c:

static int alarmtimer_rtc_add_device(struct device *dev,
				struct class_interface *class_intf)
{
...
	if (!device_may_wakeup(rtc->dev.parent)) // dev.parent = tps6586x rtc
		return -1;

I've sent V2 with changed description.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/