Re: [PATCH] msm: iommu: fix leak and invalid access

From: David Brown
Date: Wed May 22 2013 - 18:30:19 EST


On Wed, May 15, 2013 at 12:47:03PM +0800, Libo Chen wrote:

> This patch merge two patch that I sended before:
> 1. msm: iommu: add missing platform_device_unregister() in err case
> 2. msm: iommu: no need kfree before kzalloc successful
>
> It fixes two obvious problems:
> 1. We have registered msm_iommu_driver first, and need unregister it when
> registered msm_iommu_ctx_driver fail
>
> 2. We don`t need to kfree drvdata before kzalloc successful
>
> Signed-off-by: Libo Chen <libo.chen@xxxxxxxxxx>
> ---
> drivers/iommu/msm_iommu_dev.c | 11 +++++------
> 1 files changed, 5 insertions(+), 6 deletions(-)

Acked-by: David Brown <davidb@xxxxxxxxxxxxxx>

--
sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/