Re: [PATCH] staging: speakup: fix warnings by adding __userannotations

From: Samuel Thibault
Date: Wed May 22 2013 - 17:56:50 EST


Emil Goode, le Wed 22 May 2013 20:53:09 +0200, a écrit :
> This patch fixes the following sparse warnings by adding
> __user annotations.
>
> drivers/staging/speakup/speakup_soft.c:248:34: warning:
> incorrect type in argument 1 (different address spaces)
> drivers/staging/speakup/speakup_soft.c:248:34:
> expected void [noderef] <asn:1>*dst
> drivers/staging/speakup/speakup_soft.c:248:34:
> got char *[assigned] cp
> drivers/staging/speakup/speakup_soft.c:272:40: warning:
> incorrect type in argument 1 (different address spaces)
> drivers/staging/speakup/speakup_soft.c:272:40:
> expected char const [noderef] <asn:1>*s
> drivers/staging/speakup/speakup_soft.c:272:40:
> got char const *buf
> drivers/staging/speakup/speakup_soft.c:306:17: warning:
> incorrect type in initializer (incompatible argument 2
> (different address spaces))
> drivers/staging/speakup/speakup_soft.c:306:17:
> expected long ( *read )( ... )
> drivers/staging/speakup/speakup_soft.c:306:17:
> got long ( static [toplevel] *<noident> )( ... )
> drivers/staging/speakup/speakup_soft.c:307:18: warning:
> incorrect type in initializer (incompatible argument 2
> (different address spaces))
> drivers/staging/speakup/speakup_soft.c:307:18:
> expected long ( *write )( ... )
> drivers/staging/speakup/speakup_soft.c:307:18:
> got long ( static [toplevel] *<nfile_operationsoident> )( ... )
>
> drivers/staging/speakup/devsynth.c:29:41: warning:
> incorrect type in argument 2 (different address spaces)
> drivers/staging/speakup/devsynth.c:29:41:
> expected void const [noderef] <asn:1>*from
> drivers/staging/speakup/devsynth.c:29:41: got char const *ptr
> drivers/staging/speakup/devsynth.c:62:17: warning:
> incorrect type in initializer (incompatible argument 2
> (different address spaces))
> drivers/staging/speakup/devsynth.c:62:17:
> expected long ( *read )( ... )
> drivers/staging/speakup/devsynth.c:62:17:
> got long ( static [toplevel] *<noident> )( ... )
> drivers/staging/speakup/devsynth.c:63:18: warning:
> incorrect type in initializer (incompatible argument 2
> (different address spaces))
> drivers/staging/speakup/devsynth.c:63:18:
> expected long ( *write )( ... )
> drivers/staging/speakup/devsynth.c:63:18:
> got long ( static [toplevel] *<noident> )( ... )
>
> Signed-off-by: Emil Goode <emilgoode@xxxxxxxxx>

Acked-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/