Re: PING^7 (was Re: [PATCH v2 00/14] Corrections and customizationof the SG_IO command whitelist (CVE-2012-4542))

From: Paolo Bonzini
Date: Wed May 22 2013 - 17:13:08 EST


Il 22/05/2013 22:39, Tejun Heo ha scritto:
> Hey,
>
> On Wed, May 22, 2013 at 05:53:34PM +0200, Paolo Bonzini wrote:
>> I do listen to review feedback, but I also expect the other side to
>> listen to me, ask me what is not clear, and possess some knowledge of
>> the domain that he's reviewing patches for. All of which, quite
>> frankly, I have not seen in this case.
>
> Heh, nice one. As we've talked on RH mailing list, I don't doubt this
> has been a pretty bad experience for you but it also has been one of
> the worst review experiences for me too.

I can imagine. Sorry about that.

> I'm not saying you don't listen to reviews at all but the reception
> definitely feels very low-gain.

Frankly, I can say the same with s/reviews/explanations/...

> Anyways, at this point, the easiest way to make forward progress is
> completely separating out security fix from the rest along with the
> "count me out" knob, which should be able to cover most of the
> described use cases anyway. Let's please do further modifications to
> the filtering table as a separate step.

Okay, we seem to have reverted (both of us) to a more civil tone, and I
appreciate setting a way forward.

I'll send three separate series in the next few days. I guess it's okay
to send the common patch twice.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/