Re: [PATCH] regulator: ab8500-ext: Don't register withoutinitialisation data

From: Mark Brown
Date: Wed May 22 2013 - 11:59:34 EST

On Wed, May 22, 2013 at 01:47:33PM +0100, Lee Jones wrote:
> This patch fixes a bug introduced in the v3.10 merge window.
> Some platforms will not want external registers. Rather than setting up
> lots of different clauses in the core ab8500 regulator driver not to
> call ab8500-ext init() we just won't pass the initialisation data from
> platform code. This patch checks for it and if it's missing, we won't
> register the external regulators.

This seems problematic - if the regulators are unused then they
shouldn't have anything enabled in the constraints and the regulator
driver ought to be read only in which case it doesn't matter if it's
running or not, the worst that should happen is that the state can be
read back. I'd therefore expect the fix here to be in the board side
code that enables the regulators.

Attachment: signature.asc
Description: Digital signature