Re: [PATCH 13/15] chipidea: Allow user to select PCI/IMX options

From: Alexander Shishkin
Date: Wed May 22 2013 - 07:11:04 EST


Jiri Slaby <jslaby@xxxxxxx> writes:

> On 05/16/2013 11:36 AM, Alexander Shishkin wrote:
>> The benefit from compiling it on non-arm (or non-imx) architectures for
>> me is compilation testing. We don't have a whole lot of architectures
>> with CONFIG_OF so it's nice to give it a stretch.
>
> Yes, the newly added COMPILE_TEST config option will do the job. Stay
> tuned...

Seems to do the trick.

>> If you really want to save space in your rpm package, I would suggest
>> you add a condition to Makefile (ifeq ($(ARCH),arm) or something like
>> that) instead of a Kconfig option. I would prefer at least to avoid the
>> unnecessary kconfig option creep.
>
> Uhuh, why should *users* patch the kernel prior building it with
> allmodconfig? We do not want to carry *any* patches with our kernels.

I meant that instead of adding more options we could use the existing
ones in a Makefile, not that you do that in distro kernel only. But
COMPILE_TEST seems to fit the bill quite nicely anyway.

Regards,
--
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/