Re: [RFC PATCH v2, part 2 14/18] PCI, EDAC: use hotplug-safe PCIbus iterators to walk PCI buses

From: Gu Zheng
Date: Wed May 22 2013 - 00:15:15 EST


On 05/15/2013 12:51 AM, Jiang Liu wrote:

> Enhance EDAC drviers to use hotplug-safe iterators to walk PCI buses.
>
> Signed-off-by: Jiang Liu <jiang.liu@xxxxxxxxxx>
> Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
> Cc: Doug Thompson <dougthompson@xxxxxxxxxxxx>
> Cc: linux-edac@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> ---
> drivers/edac/i7core_edac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/edac/i7core_edac.c b/drivers/edac/i7core_edac.c
> index 0ec3e95..39d5823 100644
> --- a/drivers/edac/i7core_edac.c
> +++ b/drivers/edac/i7core_edac.c
> @@ -1296,7 +1296,7 @@ static unsigned i7core_pci_lastbus(void)
> int last_bus = 0, bus;
> struct pci_bus *b = NULL;
>
> - while ((b = pci_find_next_bus(b)) != NULL) {
> + for_each_pci_root_bus(b)

missing the "{":
+ for_each_pci_root_bus(b) {

> bus = b->number;
> edac_dbg(0, "Found bus %d\n", bus);
> if (bus > last_bus)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/