Re: [PATCHv4 27/39] x86-64, mm: proper alignment mappings with hugepages

From: Dave Hansen
Date: Tue May 21 2013 - 18:56:48 EST

On 05/11/2013 06:23 PM, Kirill A. Shutemov wrote:
> +static inline unsigned long mapping_align_mask(struct address_space *mapping)
> +{
> + if (mapping_can_have_hugepages(mapping))
> + return PAGE_MASK & ~HPAGE_MASK;
> + return get_align_mask();
> +}

get_align_mask() appears to be a bit more complicated to me than just a
plain old mask. Are you sure you don't need to pick up any of its
behavior for the mapping_can_have_hugepages() case?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at