Re: [PATCH v3 net-next 1/4] net: implement support for low latencysocket polling

From: Eliezer Tamir
Date: Tue May 21 2013 - 15:26:17 EST

On 21/05/2013 20:51, Eric Dumazet wrote:
On Tue, 2013-05-21 at 10:48 -0700, Eric Dumazet wrote:

We do not keep skb->dev information once a packet leaves the rcu
protected region.

Once packet is queued to tcp input queues, skb->dev is NULL.

This is done in tcp_v4_rcv() & tcp_v6_rcv()

So if we move calling sk_mark_ll() into the rcu protected region,
We would not need the gen id in the skb.
We could save skb->dev and skb->queue_mapping along with the generation id in the socket.

then we don't need to change the skb struct at all.
skb_mark_ll() can go away.
we also call sk_mark_ll in one central place in net_protocol->handler instead of all over the place.

or am I missing something?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at