Re: [PATCH] TTY:vt: convert remain take_over_console's users to do_take_over_console

From: Peter Hurley
Date: Tue May 21 2013 - 11:49:13 EST

On 05/21/2013 10:42 AM, Wang YanQing wrote:
On Tue, May 21, 2013 at 09:10:33AM -0400, Peter Hurley wrote:
I would rather revert dc9641895abb which purported to delete
_unneeded_ functions than have this. Obviously the functions
were needed.

Hi Peter, this series patches' goal is to reduce codes'
redundance and function duplication. But if we keep take_over_console,
then we have to rewrite it as a trivial wrapper over do_take_over_console,
or we have to keep bind_con_driver and register_con_driver, and this
will bring use codes' redundance.

And if we rewrite take_over_console as a wrapper over
do_take_over_console, it is so trivial, delete it and let kernel
use the unified version of APIs will simplify the APIs.

Except now you're spreading the brokenness that is console_lock()
over many more source files than the single-use case of

The actual interface is take_over_console(); the _workaround_ is
exposing do_take_over_console() for fbcon to wrap.

Peter Hurley

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at