Re: [PATCH] Revert "x86-64, init: Do not set NX bits on non-NXcapable hardware"

From: Linus Torvalds
Date: Mon May 20 2013 - 13:21:17 EST


On Mon, May 20, 2013 at 9:43 AM, Michal Hocko <mhocko@xxxxxxx> wrote:
>
> The configuration has been posted in the referenced thread:
> https://lkml.org/lkml/2013/5/14/398

Hmm. That's a regular intel i5 Sandybridge CPU. Which certainly has NX.

Hmm. secondary_startup_64 isn't __initcode, is it? I think it's used
for resuming the other CPU's too and for CPU hotplug. Yes/no?

If so early_pmd_flags shouldn't be __initdata, I think.

Michal, does it work if you don't do the revert, but just remove the
__initdata instead?

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/