Re: [PATCH] Revert "x86-64, init: Do not set NX bits on non-NX capablehardware"

From: H. Peter Anvin
Date: Mon May 20 2013 - 11:59:32 EST


On 05/20/2013 08:03 AM, Michal Hocko wrote:
> This reverts commit 78d77df71510a96e042de7ba6dbd7998103642cb because
> it breaks resume from suspend to ram. Git bisect pointed to this patch
> and the revert fixes the problem.
>
> There are no error messages neither during suspend not on resume when
> the machine simply starts booting as if it wasn't suspended in RAM at
> all.

Machine details and configuration, please? This is one of a series of
extremely bizarre suspend to RAM failures we are trying to make sense
of... in this case, it means that somehow switching from setting the NX
bit conditionally to unconditionally somehow fixes suspend to RAM!

Needless to say, this is not just bizarre, this is extremely disturbing.

-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/