[PATCH] spi: topcliff-pch: Pass correct pointer to free_irq()

From: Lars-Peter Clausen
Date: Mon May 20 2013 - 11:55:10 EST

free_irq() expects the same pointer that was passed to request_irq(), otherwise
the IRQ is not freed.

The issue was found using the following coccinelle script:

type T;
T devid;
request_irq(..., devid)

type r1.T;
T devid;
position p;
free_irq@p(..., devid)

position p != r2.p;

Signed-off-by: Lars-Peter Clausen <lars@xxxxxxxxxx>
drivers/spi/spi-topcliff-pch.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c
index 35f60bd..963e0f3 100644
--- a/drivers/spi/spi-topcliff-pch.c
+++ b/drivers/spi/spi-topcliff-pch.c
@@ -1487,7 +1487,7 @@ static int pch_spi_pd_probe(struct platform_device *plat_dev)
return 0;

- free_irq(board_dat->pdev->irq, board_dat);
+ free_irq(board_dat->pdev->irq, data);
pch_spi_free_resources(board_dat, data);

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/